Skip to content

fix: use codersdk functions for validating name attributes #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2024
Merged

fix: use codersdk functions for validating name attributes #130

merged 4 commits into from
Nov 7, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Nov 5, 2024

rather than using regex that may drift over time, we should just use the functions provided by codersdk to validate name attributes

@aslilac aslilac requested a review from ethanndickson November 5, 2024 21:50
ethanndickson
ethanndickson approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this, this is much better! I actually moved the name validators from coderd into codersdk back in september and then forgot to use them here once the release came out 😭

@aslilac aslilac merged commit d0f5e21 into main Nov 7, 2024
13 checks passed
@aslilac aslilac deleted the lilac/codersdkvalidator branch November 7, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @ethanndickson